“ Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text.”
Isn’t this how protected branches and github review functionality works anyways? What does this module add?
Possibly it was not so 6 years ago when the repository was initially made? Of course considering that this is the Gitea fork, their goal might not be the use for Github.
Yes, and it has a number of other features, but it's behind a paywall. So perhaps this is for those that want some of those features but don't want to pay.
"LGTM is a simple pull request approval system using GitHub protected branches and maintainers files or maintainers groups. Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text."
I thought it meant "Let's Get This Merge" like it was a play on "let's get this bread". I know it stands for "Looks Good To Me" now but I still prefer my reading :)
Urban Dictionary does have Let's Get This Merged as its second definition, but it's at a net of -121 points, whereas Looks Good To Me is at net 941, and was added 10 years earlier. That doesn't seem ambiguous to me.
Isn’t this how protected branches and github review functionality works anyways? What does this module add?