Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Static analysis tools and peer reviews can catch different types of issues, though. Just like a statically compiled language can catch some bugs that a dynamic language would not; but not everything. I'm a big fan of peer reviews, and I tend to focus my comments on

- This won't do what you appear to be expecting it to

- This will prevent <some other feature we're likely to need> from being implemented; at least without a much higher cost

- This will work, but is very hard to understand; it will negatively impact maintenance. Consider doing it this other way, or adding an explanation about what's going on

- This code is ok, but might read/work better <this other way>. I'm not failing the review because of it, but it's worth keeping in mind for future code.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: