Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Many code bases that I've worked on suffered from too much, and badly engineered, code - not from not having enough code.

Yes, you can go to extremes, and some people are annoyingly nitpicky when it doesn't matter. But generally, code is often a liability, stuff that is hard to understand (or even potentially subtly wrong) will cause issues down the line, and so on. Code review helps mitigate these issues, something which I think is one of the few empirical results we actually have. Plus, it also spreads knowledge about the code base.

The submission is in any case not pointing out that code review itself is bad (or even that having to adapt to a new code style is the problem), but rather the whole bureaucracy around it. Code reviews are good when the turnaround is swift.



> Many code bases that I've worked on suffered from too much, and badly engineered, code - not from not having enough code.

Because the projects that weren't built fast enough were eventually thrown away, meaning they never require maintenance, which is the source of the sampling bias you are observing. I've seen it happen in some cases (engineer with the wrong personality leading an R&D project).


But not every code base is in an early startup phase. Once the company is stable there isn't really any excuse to knock out underengineered garbage just to get something out of the door.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: